[PATCH v4] powerpc: 64K page support for kexec
lukebr at linux.vnet.ibm.com
Sat Apr 28 03:30:45 EST 2007
On Fri, 2007-04-27 at 11:59 -0500, Milton Miller wrote:
> I see I've achived my nefarious goal of making these bugs never happen.
> (panic is a function, so you are checking that the staticly linked
> non-weak function is available. If you want to check on when
> if its a panic kdump or not, you need to decode the flag and pass
> it to kexec_sequence, pass it back here, and update all platforms
> for the new parameter).
> But I still say the check while clearing the table is too late,
> it should be a debug scan before clearing any mappings.
How about the following as an alternative.
BUG_ON((hpte_v & 0x4000000000000000UL) && (crashing_cpus == -1));
BUG_ON((size == MMU_PAGE_16G) && (crashing_cpus == -1));
BUG_ON((size == MMU_PAGE_64K_AP) && (crashing_cpus == -1));
I don't have time to work on a multi-platform solution.
More information about the Linuxppc-dev