Fwd: [PATCH] Avoid putting cpu node twice

[John Rigby]

This was originally sent to linuxppc-embedded.

---------- Forwarded message ----------
From: Sylvain Munaut <tnt at 246tnt.com>
Date: Apr 7, 2007 12:22 PM
Subject: Re: [PATCH] Avoid putting cpu node twice
To: John Rigby <jcrigby at gmail.com>
Cc: Linuxppc-embedded <Linuxppc-embedded at ozlabs.org>, Grant Likely
<grant.likely at secretlab.ca>


John Rigby wrote:
> Call of_find_node_by_type with NULL instead of np
> so the cpu node does not get put twice.
> This was causing kref_put warnings.
>
> Signed-off-by: John Rigby <jrigby at freescale.com>
Acked-by: Sylvain Munaut <tnt at 246tNt.com>

> ---
> arch/powerpc/platforms/52xx/lite5200.c |    6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/52xx/lite5200.c
> b/arch/powerpc/platforms/52xx/lite5200.c
> index cc3b40d..d2f90eb 100644
> --- a/arch/powerpc/platforms/52xx/lite5200.c
> +++ b/arch/powerpc/platforms/52xx/lite5200.c
> @@ -108,9 +108,11 @@ static void __init lite5200_setup_arch(void)
>        lite5200_setup_cpu();   /* Platorm specific */
>
> #ifdef CONFIG_PCI
> -       np = of_find_node_by_type(np, "pci");
> -       if (np)
> +       np = of_find_node_by_type(NULL, "pci");
> +       if (np) {
>                mpc52xx_add_bridge(np);
> +               of_node_put(np);
> +       }
> #endif
>
> #ifdef CONFIG_BLK_DEV_INITRD
> --
> 1.5.0.6
>