[PATCH 9/13] powerpc: Add arch/powerpc mv64x60 I2C platform data setup

Mark A. Greer mgreer at mvista.com
Thu Apr 26 16:48:30 EST 2007

On Thu, Apr 26, 2007 at 04:02:16AM +0200, Arnd Bergmann wrote:
> On Thursday 26 April 2007, Mark A. Greer wrote:
> > > location is the smaller part of the problem. Even if it was the right
> > > thing to scan the tree and then create platform_data instead of using
> > > the of_device, that code would still belong into the device driver.
> > 
> > I don't think of_device is going to work very well on MIPS.
> Ok, I see your point there. But after looking at the i2c and net drivers,
> I believe that they can easily be split into an architecture dependent
> part that is either an of_platform_driver or a platform_driver, and
> a common part that does not know about either of these.

Back when I originally did the mpsc driver I did something similar.
The lkml folks told me pretty clearly to get rid of the arch-specific
code and use platform data.  All-in-all, I think that's the best solution
(until all arch's move to a device tree model).  So, I think we'll have
to agree to disagree on this.

There does seem to be a lot of duplicate code, though, so we should try
to clean that up (if possible).


More information about the Linuxppc-dev mailing list