[PATCH 3/6] Consolidate of_find_property

David Miller davem at davemloft.net
Thu Apr 26 09:13:09 EST 2007


From: Benjamin Herrenschmidt <benh at kernel.crashing.org>
Date: Thu, 26 Apr 2007 08:47:45 +1000

>  - property names. That's what you had to deal with for Sparc. I think
> it's fair enough to use strcasecmp for these. They are supposed to not
> have case, while they happen to do here or there, there is almost no
> chance of conflict (several properties with a name differring only by
> the case).
> 
>  - property content. (That include node names which are really only the
> content of the "name" property of that node). The ATA/ata case was for
> property content in fact (name property and type property iirc) which is
> a different thing and must be kept case sensitive I beleive. That covers
> the case of of_device_is_compatible() which should use strcmp (or the
> -n- version of it of course).
> 
> Do we agree on that ?

Ok, I think so.

Meanwhile any feedback on the idea of pushing all of this
consolidation and cleanup work through one of our trees
instead of having all of these difficult dependencies
between the two?

Thanks.



More information about the Linuxppc-dev mailing list