[PATCH 3/6] Consolidate of_find_property

David Miller davem at davemloft.net
Thu Apr 26 08:24:19 EST 2007

From: Benjamin Herrenschmidt <benh at kernel.crashing.org>
Date: Thu, 26 Apr 2007 08:16:44 +1000

> On Wed, 2007-04-25 at 18:46 +0100, Matt Sealey wrote:
> > Can't the ata/ATA thing be fixed by simply fixing device trees where it
> > happens? strncmp seems the standards-compliant route to take.. why clutter
> > the common parsing routines with fixes for deviant platforms?
> In that specific case, it's even fixed by having the driver have both
> spellings in it's match list.

This is something I'd like to avoid.

Initially I added sparc OFW property support to the Radeon
driver by checking for both the upper-case and lower-case
variants of all the property names.

It was beyond ugly.

I know we are talking about node names, not properties, here but
I think the same logic and reasoning applies.

> But I agree that in the long run, it's a better approach


More information about the Linuxppc-dev mailing list