[PATCH 3/6] Consolidate of_find_property

Segher Boessenkool segher at kernel.crashing.org
Wed Apr 25 23:13:31 EST 2007


>> The question is, what ppc drivers would break if we used strcmp
>> instead of strcasecmp?  I have a dim memory that some Apple machines
>> had "ata" and others had "ATA" for the hard disk, for instance.
>
> ata/ATA and ide/IDE is the main one that comes to mind, but I wouldn't
> exclude something like Powermac vs. PowerMac or that sort of thing... I
> remember a case related bug about 2 years ago but can't find what it
> was ...
>
> I think it's safe to settle on strcasecmp for most things for now

Yes, it's hard to imagine any case where strcasecmp(),
although technically incorrect, would break anything.
Please document in the code that is _is_ wrong and _why_
it is done though.


Segher




More information about the Linuxppc-dev mailing list