[PATCH 2/6] Consolidate of_device_is_compatible

David Miller davem at davemloft.net
Wed Apr 25 14:23:30 EST 2007


From: Benjamin Herrenschmidt <benh at kernel.crashing.org>
Date: Wed, 25 Apr 2007 09:59:24 +1000

> On Tue, 2007-04-24 at 22:38 +1000, Stephen Rothwell wrote:
> > The only difference here is that Sparc uses strncmp to match compatibility
> > names while PowerPC uses strncasecmp.
> 
> We should settle for a single implementation. In theory, strncmp would
> be the way to go but there have been "bugs" here or there, especially in
> Apple DTs, that made me use strncasecmp instead in the past.
> 
> Dave, what do you reckon ? I should try to find out the bogus machines
> and add workarounds in the various drivers etc... instead or we can just
> go common on strncasecmp ?

I think strncasecmp is the safest thing to start with.



More information about the Linuxppc-dev mailing list