[PATCH] pasemi: Kconfig for mdio_gpio
Arnd Bergmann
arnd at arndb.de
Wed Apr 25 07:53:06 EST 2007
On Tuesday 24 April 2007, Olof Johansson wrote:
> +config PPC_PASEMI_MDIO
> + depends on PPC_PASEMI
> + bool "MDIO support via GPIO"
> + default y
> + select PHYLIB
> + help
> + Driver for MDIO via GPIO on PWRficient platforms
> +
Looks still wrong. I stumbled over the original bug because in fedora,
CONFIG_PHYLIB=m. When you make PPC_PASEMI_MDIO a bool, it will
force PHYLIB=y, which is potentially undesired.
Can you make this a modular driver (tristate)?
Instead of making it select PHYLIB directly, it might be more
straightforward to make PPC_PASEMI_MDIO depend on PHYLIB
and have the actual network driver select both PPC_PASEMI_MDIO
and PHYLIB.
Arnd <><
More information about the Linuxppc-dev
mailing list