[PATCH 1/6] Start split out of common open firmware code

[David Miller]

From: "Loeliger Jon-LOELIGER" <jdl at freescale.com>
Date: Tue, 24 Apr 2007 07:47:10 -0700

>  
> > > +int of_n_addr_cells(struct device_node *np)
> > > +{
> > > +	const int *ip;
> > > +
> > > +	do {
> > > +		if (np->parent)
> > > +			np = np->parent;
> > > +		ip = of_get_property(np, "#address-cells", NULL);
> > > +		if (ip)
> > > +			return *ip;
> > > +	} while (np->parent);
> > > +	/* No #address-cells property for the root node */
> > > +	return OF_ROOT_NODE_ADDR_CELLS_DEFAULT;
> > > +}
> > > +EXPORT_SYMBOL(of_n_addr_cells);
> > 
> > While I realise your patch is just moving stuff around,
> > can this be fixed please?  A missing "#address-cells"
> > property means "two cells", not "inherit from parent".
> > The few platforms with a broken tree should just be
> > fixed (patch the tree in the bootwrapper, or perhaps
> > _do_ use this workaround, but only on the affected
> > platforms).
> > 
> > > +int of_n_size_cells(struct device_node *np)
> > 
> > Same here (the default is one cell though).
> 
> Agreed.  We actually discussed this quite some time ago.

I totally disagree that you should be changing anything
during these consolidations.

Move the code around in one pass where you can _VERIFY_
that things are precisely the same and won't break.

Then later you can get fancy and change things however you
wish.

You people giving comments like this have your priorities totally
screwed up and you are doing nothing but unnecessarily slowing down
this wonderful consolidation.  Even worse you might even be giving
Stephen a disincentive to keep working actively on this.

So please STOP THIS CRAP now, thanks.

Everything so far is pure whining, and has nothing to do with
the substance of what Stephen is trying to accomplish, a
_CODE CONSOLIDATION_.  So please don't get in the way of that
effort.