[patch 1/2] powerpc: add check for initialized driver data to pmi driver

Christian Krafft krafft at de.ibm.com
Tue Apr 24 04:22:23 EST 2007

From: Christian Krafft <krafft at de.ibm.com>
This patch adds a check for the private driver data to be initialized.
The bug showed up, as the caller found a pmi device by it's type.
Whereas the pmi driver probes for the type and the name.
Since the name was not as the driver expected, it did not initialize.
A more relaxed probing will be supplied with an extra patch, too.

Signed-off-by: Christian Krafft <krafft at de.ibm.com>
Signed-off-by: Arnd Bergmann <arnd.bergmann at de.ibm.com>

Index: sdk3/arch/powerpc/sysdev/pmi.c
--- sdk3.orig/arch/powerpc/sysdev/pmi.c
+++ sdk3/arch/powerpc/sysdev/pmi.c
@@ -264,6 +264,9 @@ void pmi_register_handler(struct of_devi
 	struct pmi_data *data;
 	data = device->dev.driver_data;
+	if (!data)
+		return;
 	list_add_tail(&handler->node, &data->handler);
@@ -274,10 +277,12 @@ void pmi_unregister_handler(struct of_de
 			    struct pmi_handler *handler)
 	struct pmi_data *data;
+	data = device->dev.driver_data;
-	pr_debug("pmi: unregistering handler %p\n", handler);
+	if (!data)
+		return;
-	data = device->dev.driver_data;
+	pr_debug("pmi: unregistering handler %p\n", handler);

Mit freundlichen Gruessen,
kind regards,

Christian Krafft
IBM Systems & Technology Group,
Linux Kernel Development
IT Specialist

Vorsitzender des Aufsichtsrats:	Johann Weihen
Geschaeftsfuehrung:		Herbert Kircher
Sitz der Gesellschaft:		Boeblingen
Registriergericht:		Amtsgericht Stuttgart, HRB 243294

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20070423/87016ca3/attachment.pgp>

More information about the Linuxppc-dev mailing list