[PATCH 5/7] Enable MSI mappings for MPIC
michael at ellerman.id.au
Mon Apr 23 14:10:54 EST 2007
On Sat, 2007-04-21 at 23:53 -0500, Milton Miller wrote:
> On Apr 21, 2007, at 7:06 PM, Benjamin Herrenschmidt wrote:
> >> This is just begging to be written in terms of
> >> pci_bus_find_ht_capability. Well,
> >> we have pci_bus_find_capability, and pci_find_ht_capability, I'm sure
> >> we could
> >> create that. It also means this and the other nearby functions want
> >> to be
> >> written in terms of a struct pci_bus and config accessors.
> > A lot of that code has to run way before the PCI config stuff is even
> > useable and certainly before the PCI layer data structures have been
> > created.... Sucks but that's how it is for now. We might be able to
> > tweak and delay init of the APICs etc... but I don't think I can be
> > bothered for now as it's a bit of a corner case.
> I wasn't proposing to make the code wait until the pci layer had
> discovered the ht bridge. Rather I was thinking that a struct
> pci_bus instance created for the purpose with only ops and maybe
> sysdata initialized. The purpose being to reuse the generic code.
That'd be nice in a way. Although there'd be scope for breakage from
time to time as PCI changes get made without taking into account this
> Maybe I'll have to code something up. Perhaps when I'm a bit
> less overloaded.
All yours :)
OzLabs, IBM Australia Development Lab
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: This is a digitally signed message part
More information about the Linuxppc-dev