[PATCH 10/10] zImage wrapper for Ebony

Scott Wood scottwood at freescale.com
Thu Apr 19 02:14:41 EST 2007


On Wed, Apr 18, 2007 at 04:36:26PM +1000, David Gibson wrote:
> Index: working-2.6/arch/powerpc/boot/wrapper
> ===================================================================
> --- working-2.6.orig/arch/powerpc/boot/wrapper	2007-04-18 14:40:39.000000000 +1000
> +++ working-2.6/arch/powerpc/boot/wrapper	2007-04-18 14:42:58.000000000 +1000
> @@ -141,6 +141,12 @@ miboot|uboot)
>      ksection=image
>      isection=initrd
>      ;;
> +*-tree)
> +    platformo=$object/"${platform%%-tree}".o
> +    ;;
> +*-uboot)
> +    platformo=$object/"${platform%%-uboot}".o
> +    ;;
>  esac

Perhaps we should have separate platform file and image type arguments,
so the wrapper doesn't have to do this sort of manipulation?

> +*-uboot)
> +    mv "$ofile" "$ofile.elf"
> +    version=`${CROSS}strings "$kernel" | grep '^Linux version [-0-9.]' | \
> +	cut -d' ' -f3`
> +    if [ -n "$version" ]; then
> +	version="-n Linux-$version"
> +    fi
> +    entry=`objdump -f "$ofile.elf" | grep '^start address ' | \
> +	cut -d' ' -f3`

Should be ${CROSS}objdump.  Plus, it'd be nice to factor out the version
and entry determination so that it isn't repeated for each image type
(the cuImage patch does this for version).

-Scott



More information about the Linuxppc-dev mailing list