[PATCH] [5/5] pasemi: GPIO MDIO of_platform driver

Olof Johansson olof at lixom.net
Tue Apr 17 10:47:38 EST 2007


On Tue, Apr 17, 2007 at 01:07:12AM +0200, Arnd Bergmann wrote:
> On Monday 16 April 2007, Olof Johansson wrote:
> > +static int __devinit hack_init(void)
> > +{
> > +???????struct platform_device *pdev;
> > +
> > +???????pdev = platform_device_register_simple("gpio-mdio-bitbang", 0, NULL, 0);
> > +
> > +???????return 0;
> > +}
> > +late_initcall(hack_init);
> 
> Why do you need this? The name already suggests that you are aware that this
> should be autoprobed, but it would be good to have a comment explaining
> why you did it this way.

Because I'm an idiot and forgot to take it away before posting. :-)
Thanks, will clean it up.


-Olof



More information about the Linuxppc-dev mailing list