[PATCH 1/4] powerpc: document max-speed and interface-type properties

Kumar Gala galak at kernel.crashing.org
Tue Apr 17 04:19:08 EST 2007

On Apr 16, 2007, at 12:28 PM, Andy Fleming wrote:

> On Apr 12, 2007, at 02:06, Segher Boessenkool wrote:
>>> +   - max-speed : The maximum speed supported by the controller (in
>>> Mbit/s)
>>> +   - interface-type : a string naming the controller/PHY interface
>>> type,
>>> +     i.e., one of "mii", "gmii", "sgmii", "tbi", "rmii",  
>>> "rgmii", or
>>> "rtbi".
>> This information should be in the PHY node, instead.
>> Both property values would normally be implied by
>> "compatible" in that node (and this node, for the
>> max speed).
> Why should it be in the PHY node?  It's not a property of the PHY.
> It's a property of the connection between the PHY and the ethernet
> controller.  The PHY Lib API has the ethernet provide the connection
> type as an argument in the phy_connect() call, so it makes sense for
> this property to reside in the ethernet node.  I think ethernet
> drivers typically have the most power in this situation, and so it's
> best (IMHO) to let the ethernet node provide this information.

The interface type should be a property of the phy because its a  
property of the physical 'phy' device on the board.

- k

More information about the Linuxppc-dev mailing list