[PATCH 1/4 v2] powerpc: document max-speed and interface-type properties

Kumar Gala galak at kernel.crashing.org
Tue Apr 17 01:34:07 EST 2007

On Apr 16, 2007, at 10:25 AM, Kim Phillips wrote:

> On Fri, 13 Apr 2007 21:02:25 +0200
> Segher Boessenkool <segher at kernel.crashing.org> wrote:
>>> Since ucc_geth is being migrated to use the phylib, the existing
>>> (undocumented) 'interface' property is being deprecated in favour
>>> of unconjoined variations 'max-speed' and 'interface-type'.
>> Again, please explain why this information shouldn't
>> be in the PHY node instead?
> Strictly speaking, it should be neither in the UCC node nor the PHY
> node, as it describes the connection between the two, but..
> the UCC driver utilizes the data itself; the UCC, unlike other network
> controllers, does not provide interface data in its programming model.
> the phy drivers are not of_ drivers.  Porting phylib drivers to be of_
> drivers would break phylib for non-OF arches, e.g. x86.

Nothing stops the code in the UCC driver from grabbing the phy device  
node and pulling the information out if it.

I believe the question is about where the information should truly  
live.  It would seem to be more of a property of the phy than of the  
enet controller.

- k

More information about the Linuxppc-dev mailing list