[PATCH] powerpc: Fix PowerPC 750CL CPU features
Benjamin Herrenschmidt
benh at kernel.crashing.org
Fri Apr 13 12:28:30 EST 2007
> The difference between these two is
>
> #define CPU_FTRS_750GX (CPU_FTR_DUAL_PLL_750FX | CPU_FTR_HAS_HIGH_BATS)
> #define CPU_FTRS_750 (CPU_FTR_COMMON)
>
> 750GX excludes COMMON, which seems like a bug. With
> your change, 750CL uses DUAL_PLL_750FX; does it actually
> have that feature?
Looks indeed like that lack of COMMON in the GX entry is a bug...
Josh, care to fix that too while at it ? :-)
> Either way, it seems a good idea to create a CPU_FTRS_750CL,
> the CL is an evolution of the CX, not the FX/GX (in name
> at least, dunno about the gory details).
Agreed.
> > - .cpu_setup = __setup_cpu_750cx,
> > + .cpu_setup = __setup_cpu_750fx,
>
> Same thing here. Are you sure 750CL doesn't need
> the NAP workaround? [Is anyone sure the 750CX
> actually needs it -- the comment in cpu_setup_6xx.S
> doesn't instill much confidence.]
Agreed too.
Ben.
More information about the Linuxppc-dev
mailing list