[PATCH,RFC] Split out common parts of prom.h

David Miller davem at davemloft.net
Thu Apr 12 14:25:48 EST 2007


From: Stephen Rothwell <sfr at canb.auug.org.au>
Date: Thu, 12 Apr 2007 14:19:05 +1000

> This applies on top of all the previous patches I sent (including a merge
> of the sparc64 and powerpc for-2.6.22 trees).  So if people can't get it
> to apply, at least I would like some comments on the direction. (I told
> Rusty about the circular inclusion below and he didn't throw up, so I
> figure it isn't too bad as a temporary measure.)
> 
> I have built allmodconfig (modified slightly) for Powerpc, Sparc64 and
> Sparc.  (All of which fail during the module post processing but for
> reasons not related to these patches as far as I can see.)

This is one approach, and I'm not against it.

Another way is to create a linux/openfw.h that does nothing
but include asm/prom.h as step 1.  Step 2 is to convert all
the include sites, and step 3 is to move the relevant
prom.h bits into openfw.h

To be honest, since you're the one doing all of the hard work I think
you should be allowed to make the choice on how to go about this :-)



More information about the Linuxppc-dev mailing list