[PATCH 1/4] powerpc: document max-speed and interface-type properties

[Olof Johansson]

On Wed, Apr 11, 2007 at 01:09:13PM -0500, Kim Phillips wrote:
> On Tue, 10 Apr 2007 20:49:58 -0500
> olof at lixom.net (Olof Johansson) wrote:
> 
> > On Tue, Apr 10, 2007 at 06:19:49PM -0500, Kim Phillips wrote:
> > > On Tue, 10 Apr 2007 17:48:09 -0500
> > > olof at lixom.net (Olof Johansson) wrote:
> > > 
> > > > 
> > > > Do you really need to set max speed for devices that are at the default
> > > > max speed for the interface type? Seems redundant.
> > > > 
> > > > If for example there's an rgmii interface that for some reason only can
> > > > handle 100Mbit, that'd be different.
> > > 
> > > rgmii at 100/10Mbit are supported interface/speed combinations for our MDS boards; see pdf p. 72 in:
> > > 
> > > http://www.freescale.com/files/32bit/doc/user_guide/MPC8360EAMDSUM.pdf
> > 
> > Right, my bad. Sorry for the confusion -- That comment was meant for the
> > next patch in the series where you specify the speed even for interfaces
> > that support the full max.
> > 
> just to be clear, you want the logic in ucc_geth (phylib
> patch) to be enhanced such that it sets the maximum max-speed
> based on the interface-type, e.g. if rgmii specified and
> max-speed not specified, assign max-speed = 1000?

Yes, that would seem logical, wouldn't it?


-Olof