[PATCH]: ppc64/pseries: null iommu dma-window property.

Linas Vepstas linas at austin.ibm.com
Wed Apr 11 06:11:23 EST 2007

Plese apply.


Some versions of pSeries firmware fail to set up a 
dma-window property for PCI slots that are unoccupied.
As a result, the loop searching for this propery, in
pci_dma_dev_setup_pSeriesLP(), can run to the end, resulting
in a NULL pointer dereference later in the routine. This
patch prevents the crash, and prints a warning message.

This is theoretically a rare error, as it occurs on what
is hopefully just beta levels of firmware. But just in case
this firmware escapes into the wild, this patch will avoid
the crash.

Signed-off-by: Linas Vepstas <linas at austin.ibm.com>

 arch/powerpc/platforms/pseries/iommu.c |    6 ++++++
 1 file changed, 6 insertions(+)

Index: linux-2.6.21-rc4-git4/arch/powerpc/platforms/pseries/iommu.c
--- linux-2.6.21-rc4-git4.orig/arch/powerpc/platforms/pseries/iommu.c	2007-02-04 12:44:54.000000000 -0600
+++ linux-2.6.21-rc4-git4/arch/powerpc/platforms/pseries/iommu.c	2007-04-10 15:05:30.000000000 -0500
@@ -526,6 +526,12 @@ static void pci_dma_dev_setup_pSeriesLP(
+	if (!pdn || !PCI_DN(pdn)) {
+		printk(KERN_WARNING "pci_dma_dev_setup_pSeriesLP: "
+		       "no DMA window found for pci dev=%s dn=%s\n",
+				 pci_name(dev), dn? dn->full_name : "<null>");
+		return;
+	}
 	DBG("  parent is %s\n", pdn->full_name);
 	/* Check for parent == NULL so we don't try to setup the empty EADS

More information about the Linuxppc-dev mailing list