[PATCH v2] powerpc: change rheap functions to use ulongs instead of pointers

Kumar Gala galak at kernel.crashing.org
Wed Apr 11 05:04:44 EST 2007


On Apr 10, 2007, at 1:46 PM, Timur Tabi wrote:

> Kumar Gala wrote:
>
>> If we are "cleaning up" rheap I would suggest we think about  
>> moving  it to the generic lib directory and have it available for  
>> wider use  beyond powerpc.
>
> I'm not saying that's a bad idea, but that really is outside the  
> scope of my intentions. I'm not really cleaning up rheap as I am  
> fixing one specific problem.

What's the specific problem you are fixing?  Its not obvious that  
this patch is addressing a bug.

> I don't think there's any disagreement here that an integer type  
> (in this case, unsigned long) is better than a void * for storing a  
> generic value.  I was really hoping I could get a consensus on  
> whether or not *this* patch is good for *our* rheap implementation.

- k



More information about the Linuxppc-dev mailing list