[PATCH v2] powerpc: change rheap functions to use ulongs instead of pointers

Kumar Gala galak at kernel.crashing.org
Wed Apr 11 04:31:52 EST 2007


On Apr 9, 2007, at 4:25 PM, Timur Tabi wrote:

> Timur Tabi wrote:
>> The rheap allocation functions return a pointer, but the actual  
>> value is based
>> on how the heap was initialized, and so it can be anything, e.g.  
>> an offset
>> into a buffer.  A ulong is a better representation of the value  
>> returned by
>> the allocation functions.
>
> No comments on this patch?  Does this mean that you all think it's  
> okay for 2.6.22?

If we are "cleaning up" rheap I would suggest we think about moving  
it to the generic lib directory and have it available for wider use  
beyond powerpc.

This would also mean getting a wide review by lkml and seeing what  
people think about it returning a ulong vs void *.

- k



More information about the Linuxppc-dev mailing list