[PATCH] powerpc: change rheap functions to use long integers instead of pointers

Dan Malek dan at embeddedalley.com
Thu Apr 5 05:15:01 EST 2007


On Apr 4, 2007, at 2:13 PM, Timur Tabi wrote:

> How about I change rh_alloc() to return unsigned long, instead of  
> just long, and then the
> callers can use IS_ERR_VALUE() to check for error?

How about just leaving it alone?  A void * is
perfectly valid as rheap could be used to manage
any address space.  It isn't a bug, you are reducing
it's capability (by taking it's object management
outside of the kernel virtual space), and you are
introducing concerns for error conditions of
current users.

Thanks.


	-- Dan





More information about the Linuxppc-dev mailing list