[Cbe-oss-dev] cbe_cpufreq.c initialisation

[Stephen Rothwell]

On Tue, 03 Apr 2007 18:37:31 +1000 Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote:
>
> On Tue, 2007-04-03 at 18:20 +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > In cbe_cpufreq_cpu_init, there is this code:
> >
> > 	max_freq = (u32*) get_property(cpu, "clock-frequency", NULL);
> >         // we need the freq in kHz
> >         *max_freq /= 1000;
> >
> > does this really need to modify the property value in place?
>
> No, that's obviously a bug...

Excellent, because that was the last non-const usage of get_property in
the whole tree :-)

--
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20070403/a49e2965/attachment.pgp>