[PATCH 7/9] Add MPC8360EMDS board support

Li Yang-r58472 LeoLi at freescale.com
Sat Sep 30 21:39:38 EST 2006


> > +
> > +static u8 *bcsr_regs = NULL;
> > +
> > +u8 *get_bcsr(void)
> > +{
> > +	return bcsr_regs;
> > +}
> 
> Does anything outside of this file use this?  If so, its broken since
> you iounmap(bcsr_regs) when you reset the enet phy.  If nothings
> using it, than drop the header extern and the header file.

Oops, this is a bug introduced in bcsr change.  I have fixed it in the
latest patch.  Current external user of bcsr is a workaround in ucc_geth
phy code.

- Leo



More information about the Linuxppc-dev mailing list