[PATCH 6/9] qe_lib: Add QE SoC support

[Kumar Gala]

On Sep 29, 2006, at 11:37 PM, Li Yang-r58472 wrote:

>
>> -----Original Message-----
>> From: Kumar Gala [mailto:galak at kernel.crashing.org]
>> Sent: Friday, September 29, 2006 10:13 PM
>> To: Li Yang-r58472
>> Cc: paulus at samba.org; linuxppc-dev at ozlabs.org
>> Subject: Re: [PATCH 6/9] qe_lib: Add QE SoC support
>>
>>
>> On Sep 29, 2006, at 5:35 AM, Li Yang wrote:
>>
>>> Signed-off-by: Li Yang <leoli at freescale.com>
>>> Signed-off-by: Kim Phillips <kim.phillips at freescale.com>
>>>
>>> ---
>>>  arch/powerpc/sysdev/qe_lib/qe.c |  176 ++++++++++++++++++++++++++++
>>> +++++++++++
>>>  include/linux/fsl_devices.h     |   39 ++++++++-
>>>  2 files changed, 214 insertions(+), 1 deletions(-)
>>
>> As I've stated in the past make this use of_device instead of
>> platform_device.
>
> As I've argued before, there are currently many off-the-tree user  
> of ppc
> arch on 8360, and we must still support that.  Change the ucc_geth
> driver to use of_device will add the effort of maintaining two  
> versions
> of ucc_geth driver for us (one for ppc, one for powerpc).  Do you  
> really
> think it is so important to replace platform_device with of_device?  I
> didn't see any true benefit of doing so.

I dont see why you need to maintain an arch/ppc version as everything  
related to 8360 is arch/powerpc.  If you guys have some internal  
stuff that is your own issue to manage.  This is a new device and  
thus should use of_device.  My goal is to eventually move the other  
users of platform_device over to of_device when they aren't being  
sured with arch/ppc in the public tree.

- kumar