[PATCH 11/12] Add MPC8360EMDS default dts file

Vitaly Bordug vbordug at ru.mvista.com
Fri Sep 29 22:50:05 EST 2006


On Fri, 29 Sep 2006 15:46:57 +0800
"Li Yang-r58472" <LeoLi at freescale.com> wrote:

> > -----Original Message-----
> > From: Vitaly Bordug [mailto:vbordug at ru.mvista.com]
> > Sent: Thursday, September 28, 2006 9:38 PM
> > To: Li Yang-r58472
> > Cc: paulus at samba.org; galak at kernel.crashing.org;
> linuxppc-dev at ozlabs.org
> > Subject: Re: [PATCH 11/12] Add MPC8360EMDS default dts file
> > 
> > On Thu, 28 Sep 2006 16:19:30 +0800
> > Li Yang <leoli at freescale.com> wrote:
> > 
> > > +		muram at 10000 {
> > > +			device_type = "muram";
> > > +			ranges = <0 00010000 0000c000>;
> > > +
> > > +			data-only at 0{
> > > +				reg = <0 c000>;
> > > +			};
> > > +		};
> > > +
> > 
> > Why not to have reg property, showing the allocation ranges? data-only
> seems
> > redundant as a node...
> 
> The reason why I added this node is to put the address under "muram"
> bus.  If I put the reg in muram node, the address will be offset to QE
> base.  But what the driver needs is the offset to MURAM base.  IMHO,
> this approach is clearer logically.
> 
Correct. 

Well, IMO the information about dataonly is conceptually overkill for dts. 
But if devicetree masters are OK - that's even better to have it:)

-- 
Sincerely, 
Vitaly



More information about the Linuxppc-dev mailing list