[PATCH] Add powerpc get/set_rtc_time interface to new generic rtc class

Benjamin Herrenschmidt benh at kernel.crashing.org
Wed Sep 27 08:01:53 EST 2006


On Tue, 2006-09-26 at 09:14 -0500, Kumar Gala wrote:
> On Sep 25, 2006, at 10:13 PM, Benjamin Herrenschmidt wrote:
> 
> > On Mon, 2006-09-25 at 21:55 -0500, Kim Phillips wrote:
> >> Add powerpc get/set_rtc_time interface to new generic rtc class. This
> >> abstracts rtc chip specific code from the platform code for rtc- 
> >> over-i2c
> >> platforms.  Specific RTC chip support is now configured under
> >> Device Drivers -> Real Time Clock. Setting time of day from the RTC
> >> on startup is also configurable.
> >>
> >> Currently, the only default config in powerpc arch is the 8349 itx.
> >> Other platforms wanting to consolidate code may also use this.
> >>
> >> Signed-off-by: Kim Phillips <kim.phillips at freescale.com>
> >
> > I think we should only get that in if we also adapt the various  
> > platform
> > RTC code to be in drivers/rtc ... right now, enabling that option will
> > just break everybody.
> 
> Maybe just drop the init call for now and let people migrate over to  
> using this and moving the drivers over to drivers/rtc which aren't  
> supported there.

Yup. We shouldn't change ppc_md from an initcall that way for something
that may not be supported by a platform. The platform code shall set
ppc_md. (maybe calling some init function for doing it) if the platform
supports the new class mecanism.

Ben.





More information about the Linuxppc-dev mailing list