[PATCH]: PCI Error Recovery: Symbios SCSI device driver

Linas Vepstas linas at austin.ibm.com
Sat Sep 23 09:32:35 EST 2006

On Sat, Sep 23, 2006 at 12:06:29AM +0200, Luca wrote:
> Space after function name? You put in other places too, it's not
> consistent with the rest of the patch.

Oops. I was also coding on a different project recently, with a
different style.  I'll send a revised patch in a moment.

> > +       if (pci_enable_device(pdev))
> > +               printk (KERN_ERR "%s: device setup failed most egregiously\n",
> > +                           sym_name(np));
> Is the failure of pci_enable_device ignored on purpose?

No. :-( Thanks for the catch. I think I got cross-eyed staring at the code.


More information about the Linuxppc-dev mailing list