[PATCH] Fix PPC32 SECCOMP, unexport do_syscall_trace_{enter,leave}

David Woodhouse dwmw2 at infradead.org
Fri Sep 22 18:32:45 EST 2006

The secure_computing() call which automatically aborts a process if it
tries to execute a syscall it shouldn't is much more useful if we
actually do it _before_ the syscall, rather than afterwards. PPC64 got
this right, but the original incorrect behaviour inherited from arch/ppc
was preserved by ifdefs. Make it the same on PPC32 too.

Also, I see no need to export do_syscall_trace_{leave,enter} on ppc32 --
they were only exported because the old do_syscall_trace() (which they
replaced) used to be.

Signed-off-by: David Woodhouse <dwmw2 at infradead.org>

diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c
index dea75d7..9c78009 100644
--- a/arch/powerpc/kernel/ptrace.c
+++ b/arch/powerpc/kernel/ptrace.c
@@ -526,9 +526,7 @@ static void do_syscall_trace(void)
 void do_syscall_trace_enter(struct pt_regs *regs)
-#ifdef CONFIG_PPC64
 	if (test_thread_flag(TIF_SYSCALL_TRACE)
 	    && (current->ptrace & PT_PTRACED))
@@ -548,10 +546,6 @@ #endif
 void do_syscall_trace_leave(struct pt_regs *regs)
-#ifdef CONFIG_PPC32
-	secure_computing(regs->gpr[0]);
 	if (unlikely(current->audit_context))
@@ -561,8 +555,3 @@ #endif
 	    && (current->ptrace & PT_PTRACED))
-#ifdef CONFIG_PPC32


More information about the Linuxppc-dev mailing list