Fw: [PATCH] Remove powerpc specific parts of 3c509 driver

Linas Vepstas linas at austin.ibm.com
Wed Sep 20 05:44:25 EST 2006


On Tue, Sep 19, 2006 at 08:52:18PM +0200, Matt Sealey wrote:
[...]
> 
> Linas Vepstas wrote:
> >On Tue, Sep 19, 2006 at 02:54:33PM +1000, Stephen Rothwell wrote:
> >>On powerpc and ppc, insl_ns and insl are identical as are outsl_ns and
> >>outsl, so remove the conditional use of insl_ns and outsl_ns.
> >
> >The rest of this patch might indeed be correct, but the above comment 
> >bothers me. The "ns" versions of routines are supposed to be
> >non-byte-swapped versions of the insl/outsl routines (which would

Never mind. Silly me don't know my history. 

asm-powerpc/io.h clearly states

 * The *_ns versions below don't do byte-swapping.
 * Neither do the standard versions now, these are just here
 * for older code.

Seems that the byteswapping machanism was changed a while ago, 
and no longer handled in this way any more.

--linas



More information about the Linuxppc-dev mailing list