[PATCH 3/7] POWERPC: Move generic cpm2 stuff to powerpc

[Stephen Rothwell]

On Sat, 16 Sep 2006 12:09:34 -0400 Dan Malek <dan at embeddedalley.com> wrote:
>
> 
> On Sep 16, 2006, at 4:36 AM, Stephen Rothwell wrote:
> 
> >
> >> +	if (brg < 4) {
> >> +		bp = (uint *)&cpm2_immr->im_brgc1;
> >> +	}
> >> +	else {
> >
> > Normally:
> > 	if (brg < 4)
> > 		bp = (uint *)&cpm2_immr->im_brgc1;
> > 	else {
> 
> Sorry, I'm going to nit-pick right back.  This isn't
> "normal", it's just your preference.  :-)
> 
> When the "else" part contains braces, the "if"
> part should as well.  If this get modified and
> nested some day in the future, this can cause
> a very subtle coding error.

Not if you are consistent (and many aren't, I agree).

I was more commenting on the

	}
	else {

bit wich should (at worst) be 

	} else {

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/