[Fwd: Re: ohci1394: steps to implement suspend/resume]
Stefan Richter
stefanr at s5r6.in-berlin.de
Fri Sep 8 05:34:21 EST 2006
Benjamin Herrenschmidt wrote:
> On Wed, 2006-09-06 at 16:46 +0200, Stefan Richter wrote:
[...]
>> We already broke your platform code once by what was meant as a bugfix
>> for non-PMacs. It'd be good to know enough to not repeat such mistakes...
>
> The PowerMac code will stop the chip clocks. It should be used as the
> last step of the suspend sequence and first step of the return sequence,
> in _addition_ to your new code.
Thanks for the help.
> Note also that the code you posted lacks calls to pci_set_power_state()...
Pavel submitted a respective patch on 2006-09-05; I will integrate them
both.
--
Stefan Richter
-=====-=-==- =--= --===
http://arcgraph.de/sr/
More information about the Linuxppc-dev
mailing list