[Alsa-devel] oops in snd-powermac due to snd-aoa

[Takashi Iwai]

At Thu, 7 Sep 2006 14:42:56 +0200,
Olaf Hering wrote:
> 
> I was playing with snd-aoa, maybe the driver would work on a G4/466.
> mv /lib/modules/*/kernel/sound/ppc/snd-powermac.ko .
> reboot
> $insmod /lib/modules/*/kernel/sound/aoa/*/*.ko
> alsamixer finds nothing.
> mv snd-powermac.ko /lib/modules/*/kernel/sound/ppc/
> $insmod snd-powermac.ko -> oops
> 
> Using PowerMac machine description
(snip)
> ALSA sound/ppc/keywest.c:82: tumbler: cannot attach i2c client
> read_audio_gpio addr 67 ret 2 av 4
> headphone: 0, lineout: 0
> check_audio_gpio addr 70 ret 4 av 4
> check_audio_gpio addr 6f ret 7 av 4
> Unable to handle kernel paging request for data at address 0x00000002

Does the patch below work?


Takashi

diff -r 4f27a5064cda ppc/keywest.c
--- a/ppc/keywest.c	Thu Sep 07 12:40:00 2006 +0200
+++ b/ppc/keywest.c	Thu Sep 07 14:54:59 2006 +0200
@@ -117,6 +117,9 @@ int __init snd_pmac_tumbler_post_init(vo
 {
 	int err;
 	
+	if (!keywest_ctx || !keywest_ctx->client)
+		return -ENXIO;
+
 	if ((err = keywest_ctx->init_client(keywest_ctx)) < 0) {
 		snd_printk(KERN_ERR "tumbler: %i :cannot initialize the MCS\n", err);
 		return err;