[PATCH] PPC 4xx: Enable XMON on PPC 4xx boards

Josh Boyer jwboyer at jdub.homelinux.org
Thu Sep 7 09:50:47 EST 2006


On Thu, 2006-09-07 at 08:55 +1000, Paul Mackerras wrote:
> Josh Boyer writes:
> 
> > -		excp->msr |= 0x400;
> > +		excp->msr |= MSR_SSTEP_ENABLE;
> > +#ifdef CONFIG_4xx
> > +		mtspr(SPRN_DBCR0, mfspr(SPRN_DBCR0) | DBCR0_IC | DBCR0_IDM);
> > +#endif
> >  	} else if (at_breakpoint(excp->nip)) {
> >  		xmon_trace[smp_processor_id()] = BRSTEP;
> > -		excp->msr |= 0x400;
> > +		excp->msr |= MSR_SSTEP_ENABLE;
> > +#ifdef CONFIG_4xx
> > +		mtspr(SPRN_DBCR0, mfspr(SPRN_DBCR0) | DBCR0_IC | DBCR0_IDM);
> > +#endif
> 
> This would be neater with a little inline xmon_enable_sstep(excp)
> function...
> 
> Other than that, looks fine.

Agreed.  I'll make that change and resend in the morning.

josh




More information about the Linuxppc-dev mailing list