[Fwd: Re: ohci1394: steps to implement suspend/resume]

Stefan Richter stefanr at s5r6.in-berlin.de
Thu Sep 7 00:46:53 EST 2006


Hello LinuxPPC-dev,

we have now patches coming in to fix up the lack of generic suspend +
resume support in drivers/ieee1394/ohci1394. Attached is the latest and
by far most functional one by Bernhard Kaindl. A big question is how
this relates to the already existing PPC-PMAC platform code in
ohci1394's suspend and resume hooks.

 - Which functionalities does the existing platform code provide in
   detail?

 - Do we have to keep platform code and generic code separate? I.e.
#ifdef CONFIG_PPC_PMAC
	...pmac_call_feature...
#else
	...new generic code...
#endif

 - Or are parts of the until now missing, new generic code necessary
   for PMacs too? If yes, is the platform code treated to be the lowest
   level as far as the oreder of code is concerned?

 - Or would the platform code be obsolete?

We already broke your platform code once by what was meant as a bugfix
for non-PMacs. It'd be good to know enough to not repeat such mistakes...

Thanks in advance,
-- 
Stefan Richter
-=====-=-==- =--= --==-
http://arcgraph.de/sr/
-------------- next part --------------
An embedded message was scrubbed...
From: Bernhard Kaindl <bk at fsfe.org>
Subject: Re: ohci1394: steps to implement suspend/resume
Date: Wed, 6 Sep 2006 14:58:30 +0200 (CEST)
Size: 8162
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20060906/487f4407/attachment.eml>


More information about the Linuxppc-dev mailing list