Please pull powerpc.git 'merge' branch

Benjamin Herrenschmidt benh at kernel.crashing.org
Mon Sep 4 07:15:22 EST 2006


On Sun, 2006-09-03 at 12:16 -0700, Linus Torvalds wrote:
> Hmm.
> 
> I wrote a sparse extension that warns if an initializer tries to 
> initialize the same entry multiple times.
> 
> Look what it found:
> 
>  - arch/powerpc/platforms/powermac/pfunc_base.c:259
> 
> 	static struct pmf_handlers macio_mmio_handlers = {
> 	        .write_reg32            = macio_do_write_reg32,
> 	        .read_reg32             = macio_do_read_reg32,
> 	        .write_reg8             = macio_do_write_reg8,
> 	        .read_reg32             = macio_do_read_reg8,

Yeah, a typo :) Go sparse !

I'll send a fix later today. I don't think the read32 is used that much
in practice, but yeah, that could have cause subtle issues on some
machine....

Ben.





More information about the Linuxppc-dev mailing list