[PATCH 1/2] Add MPC52xx Interrupt controller support for ARCH=powerpc
benh at kernel.crashing.org
Tue Oct 31 20:07:08 EST 2006
On Tue, 2006-10-31 at 10:04 +0100, Nicolas DET wrote:
> Benjamin Herrenschmidt wrote:
> >> In my point of view, the Firmware main task is to init the HW. I do not
> >> think it's a good idea to overwrite firmware hw settings in the common
> >> code. In my mind, this should be done in platform specific area.
> > The setting of interrupt polarity is a matter that is at the edge
> > between firmware and OS responsibility. Remember that a lot of embedded
> > platforms have close to no useful firmware too.
> Ok. that's why I suggest to keep buggy (or none) firmware board in
> platform specific code.
Well, in that case, we have a well defined interface to set the sense
code, via the device-tree, and that's much better than having platform
code muck around the PIC hardware separately from the PIC driver don't
you think ?
Anyway, that's the way it works in Linux/powerpc so there is no need
debating that for ever. Just be aware that at one point, there will be a
set_type() implementation in this driver and that it will be called
based on the polarity information in the device-tree so make sure you
got it right.
> > Of course, if your device-tree has bugs, then adding that feature
> > afterward will suddenly break efika ...
> Our OpenFirmware is, of course, bugfree ;-)
More information about the Linuxppc-dev