[PATCH] qe_lib: Remove immrbar_virt_to_phys() function
galak at kernel.crashing.org
Tue Oct 31 16:30:07 EST 2006
On Oct 30, 2006, at 11:25 PM, Li Yang-r58472 wrote:
>> -----Original Message-----
>> From: Kumar Gala [mailto:galak at kernel.crashing.org]
>> Sent: Tuesday, October 31, 2006 1:06 PM
>> To: Li Yang-r58472
>> Cc: Paul Mackerras; linuxppc-dev at ozlabs.org
>> Subject: Re: [PATCH] qe_lib: Remove immrbar_virt_to_phys() function
>> On Oct 30, 2006, at 8:56 PM, Li Yang-r58472 wrote:
>>>>>> I'm confused, if there are other users of immrbar_virt_to_phy()
>>>>>> can you get ride of it completely?
>>>>> Other users will change to use iopa() instead. There was some bug
>>>>> use iopa() with io_block_mapping area, but it is ok to use it now.
>>>> Hmm, what are the other users doing? I think we should avoid using
>>> Get physical address from virtual address. I have considered to use
>>> virt_to_phys(), but it is not consistent between ppc and powerpc
>> Why does that matter, qe support only exists in powerpc.
> Well, it does use include/asm-ppc/io.h instead of
> include/asm-powerpc/io.h for now. If the hack is removed, the driver
> will not work.
What uses asm-ppc/io.h instead of asm-powerpc/io.h?
More information about the Linuxppc-dev