[PATCH] qe_lib: Remove immrbar_virt_to_phys() function

Paul Mackerras paulus at samba.org
Mon Oct 30 14:21:42 EST 2006


Li Yang writes:

> Remove private physical address mapping routine in qe_lib.  Users
> of qe_lib should use generic functions like iopa().
> The change also addresses a bug found by Timur Tabi that cmd_input
> got mapped in qe_issue_cmd().  It should be written to CECDR
> unmodified.

Do you mean that the argument to qe_issue_cmd is a physical address?
It seems to me that the bug fix you mention is the main thing the
patch does, and the removal of immrvar_virt_to_phys is a cleanup on
the side that is made possible by the bugfix.

Paul.



More information about the Linuxppc-dev mailing list