[PATCH] General CHRP/MPC5K2 platform support patch

Nicolas DET nd at bplan-gmbh.de
Sat Oct 28 01:04:29 EST 2006


Nicolas DET wrote:
> Benjamin Herrenschmidt wrote:
>> On Thu, 2006-10-26 at 14:00 -0600, Grant Likely wrote:
>>> My comments are satisfied
>>>
>>> Acked-by: Grant Likely <grant.likely at secretlab.ca>
>>
>> Nack.
>>
>> The irq code doesn't properly use the genirq infrastructure. It's not
>> setting flow handlers, not implementing set_irq_type, not using the new
>> mask/unmask instead of the toplevel enable/disable...
>>
>>
> 
> Done.
> 
> We agree on IRC last night to postpone this implementation later on. 
> However, here it is.
> 
> This patch compiles fine when applied to the kernel 2.6.19-rc3. I also 
> tested gcc 3.3.5 and 4.1.2.
> 
> I made some tests and did not found any issue. However, more 
> testing/stressing/torturing and also with on others platforms is 
> required to fully validate the driver.
> 
>
>  	/* Pegasos has no MPIC, those ops would make it crash. It might be an
> diff -uprN a/include/asm-powerpc/mpc52xx.h b/include/asm-powerpc/mpc52xx.h
> --- a/include/asm-powerpc/mpc52xx.h	1970-01-01 01:00:00.000000000 +0100
> +++ b/include/asm-powerpc/mpc52xx.h	2006-10-27 15:51:55.000000000 +0200
> @@ -0,0 +1,414 @@
> +/*
> + * include/asm-ppc/mpc52xx.h
> + * 


Fixed to powerpc


> +#endif /* __ASSEMBLY__ */
> +
> +
> +#ifdef CONFIG_PCI
> +#define _IO_BASE	isa_io_base
> +#define _ISA_MEM_BASE	isa_mem_base
> +#define PCI_DRAM_OFFSET	pci_dram_offset
> +#else
> +#define _IO_BASE	0
> +#define _ISA_MEM_BASE	0
> +#define PCI_DRAM_OFFSET	0
> +#endif
> +
> +
> +/* ======================================================================== */
> +/* PPC Sys devices definition                                               */
> +/* ======================================================================== */
> +
> +enum ppc_sys_devices {
> +	MPC52xx_MSCAN1,
> +	MPC52xx_MSCAN2,
> +	MPC52xx_SPI,
> +	MPC52xx_USB,
> +	MPC52xx_BDLC,
> +	MPC52xx_PSC1,
> +	MPC52xx_PSC2,
> +	MPC52xx_PSC3,
> +	MPC52xx_PSC4,
> +	MPC52xx_PSC5,
> +	MPC52xx_PSC6,
> +	MPC52xx_FEC,
> +	MPC52xx_ATA,
> +	MPC52xx_I2C1,
> +	MPC52xx_I2C2,
> +	NUM_PPC_SYS_DEVS,
> +};
> +
> +

Removed

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: chrpmpc52xx_2.6.19-rc3.patch
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20061027/3d776a51/attachment.txt>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nd.vcf
Type: text/x-vcard
Size: 249 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20061027/3d776a51/attachment.vcf>


More information about the Linuxppc-dev mailing list