[PATCH] General CHRP/MPC5K2 platform support patch

Grant Likely grant.likely at secretlab.ca
Fri Oct 27 02:09:06 EST 2006


On 10/26/06, Grant Likely <grant.likely at secretlab.ca> wrote:
> On 10/26/06, Nicolas DET <nd at bplan-gmbh.de> wrote:
> > -       chrp_find_openpic();
> > -       chrp_find_8259();
> > +
> > +       if ( chrp_find_mpc52xx_pic() < 0)
> > +       {
> > +               chrp_find_openpic();
> > +               chrp_find_8259();
> > +       }
>
> Why?  Why not just add the call to chrp_find_mpc52xx_pic() before or
> after the other two chrp_find_ calls?  Will calling them cause things
> to break?
>
> Keep the code simple.

... as possible; but no simpler.

:)

g.

-- 
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely at secretlab.ca
(403) 399-0195



More information about the Linuxppc-dev mailing list