[PATCH] General CHRP/MPC5K2 platform support patch

[Nicolas DET]

Benjamin Herrenschmidt wrote:
> On Wed, 2006-10-25 at 21:05 +0200, Nicolas DET wrote:
> 
> In addition to various whitespace damage in the patch...
> 
>> +	if (_chrp_type ==  _CHRP_E5K2) {
>> +		ppc_md.get_irq = mpc52xx_get_irq;
>> +		mpc52xx_init_irq();
>> +		return;
>> +	}
> 
> As I wrote, the above should be unnecessary.
> 
>>  	chrp_find_openpic();
>>  	chrp_find_8259();
> 
> Just add a
> 
> 	chrp_find_mpc5200pic();
> 
> Which will set itself as the default controller and set ppc_md.get_irq
> if none have done it before.
>  
>> @@ -530,6 +540,9 @@ chrp_init2(void)
>>  	chrp_nvram_init();
>>  #endif
>>  
>> +	if (_chrp_type == _CHRP_E5K2)
>> +		return;
> 

Done.


>> +static void
>> +mpc52xx_ic_disable(unsigned int virq)
>> +{
>> +        u32 val;
>> +	int irq;
>> +
>> +	irq = irq_map[virq].hwirq;
> 
> You should test if the result is valid just in case you were called with
> [...]
> I'm surprised the revmap is working at all... considering the issues you
> have above. You are lucky but things should be fixed anyway.
> 

As said in the mail. I'm waiting for the opinion of the original authors 
and the mainteners. What's why I did not made much change in this file.
In the current patch, I know do:
mpc52xx_irqhost = irq_alloc_host(IRQ_HOST_MAP_LINEAR, NR_IRQS, 
&mpc52xx_irqhost_ops, -1);

Which should be ok.

>> --- a/arch/powerpc/sysdev/Makefile	2006-10-25 19:07:24.000000000 +0200
>> +++ b/arch/powerpc/sysdev/Makefile	2006-10-25 20:33:32.000000000 +0200
>> @@ -13,6 +13,7 @@ obj-$(CONFIG_FSL_SOC)		+= fsl_soc.o
>>  obj-$(CONFIG_PPC_TODC)		+= todc.o
>>  obj-$(CONFIG_TSI108_BRIDGE)	+= tsi108_pci.o tsi108_dev.o
>>  obj-$(CONFIG_QUICC_ENGINE)	+= qe_lib/
>> +obj-$(CONFIG_PPC_CHRP)		+= mpc52xx_pic.o
> 

Done.

Regards
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: chrpmpc52xx_2.6.19-rc3.patch
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20061026/e0864692/attachment.txt>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nd.vcf
Type: text/x-vcard
Size: 249 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20061026/e0864692/attachment.vcf>