[PATCH -rt] powerpc update
Daniel Walker
dwalker at mvista.com
Thu Oct 19 00:32:21 EST 2006
On Wed, 2006-10-18 at 09:28 +0200, Ingo Molnar wrote:
> * Daniel Walker <dwalker at mvista.com> wrote:
>
> > Pay close attention to the fasteoi interrupt threading. I added usage
> > of mask/unmask instead of using level handling, which worked well on
> > PPC.
>
> this is wrong - it should be doing mask+ack.
The main reason I did it this way is cause the current threaded eoi
expected the line to be masked. So if you happen to have a eoi that's
threaded you get a warning then the interrupt hangs.
> also note that you changed:
> > - goto out_unlock;
>
> to:
>
> > + goto out;
>
> and you even tried to hide your tracks:
hiding something? I made note of these changes specifically so you would
review them.
Daniel
More information about the Linuxppc-dev
mailing list