[PATCH] enable RTAS /proc for PowerPC/CHRP platform

Arnd Bergmann arnd at arndb.de
Wed Oct 18 08:22:23 EST 2006


On Tuesday 17 October 2006 15:22, Christoph Hellwig wrote:
> >       rtas_node = of_find_node_by_name(NULL, "rtas");
> >       if (rtas_node == NULL)
> >               return -ENODEV;
> 
> And given this check I wonder why we need the platform check at all.  It
> should be safe to just remove it.
> 

One difference would be that it triggers on machines running SLOF (QS20, 
some JS20/JS21) and maybe some older Macs, which is probably a good
thing.

I wonder if it should be a little stricter though:

> 	rtas_node = of_find_node_by_path("/rtas");
>	if (!rtas_node)
>		return -ENODEV;

In case there is a node called "rtas" somewhere else.

	Arnd <><



More information about the Linuxppc-dev mailing list