[PATCH 1/4] powerpc: consolidate feature fixup code

Benjamin Herrenschmidt benh at kernel.crashing.org
Thu Oct 12 20:48:40 EST 2006


> >  void __init setup_system(void)
> >  {
> > +	extern unsigned int __start___ftr_fixup, __stop___ftr_fixup;
> > +	extern unsigned int __start___fw_ftr_fixup, __stop___fw_ftr_fixup;
> 
> 
> Every extern in a C file ... god kills a kitten! :)

Well... it's a bit special in this case.. just a reference to a section,
I'd rather keep it close to the only call site...

Ben.





More information about the Linuxppc-dev mailing list