[PATCH 21/21]: powerpc/cell spidernet DMA coalescing

Benjamin Herrenschmidt benh at kernel.crashing.org
Wed Oct 11 17:15:10 EST 2006

On Tue, 2006-10-10 at 18:20 -0500, jschopp wrote:
> Linas Vepstas wrote:
> > The current driver code performs 512 DMA mappns of a bunch of 
> > 32-byte structures. This is silly, as they are all in contiguous 
> > memory. Ths patch changes the code to DMA map the entie area
> > with just one call.
> > 
> > Signed-off-by: Linas Vepstas <linas at austin.ibm.com>
> > Cc: James K Lewis <jklewis at us.ibm.com>
> > Cc: Arnd Bergmann <arnd at arndb.de>
> The others look good, but this one complicates the code and doesn't have any benefit.  20 
> for 21 isn't bad.

Hi Joel !

I'm not sure what you mean here.... (especially your 20 to 21 comment).

The patch looks perfectly fine to me, and in fact removes more lines of
code than it adds :)


More information about the Linuxppc-dev mailing list