[PATCH 4/7] Add MPC8360EMDS board support
Kumar Gala
galak at kernel.crashing.org
Wed Oct 4 04:20:35 EST 2006
On Oct 3, 2006, at 1:02 PM, Kim Phillips wrote:
> On Mon, 2 Oct 2006 22:19:14 -0500
> Kumar Gala <galak at kernel.crashing.org> wrote:
>
>> [snip]
>>
>
>>> +static u8 *bcsr_regs = NULL;
>>> +
>>> +u8 *get_bcsr(void)
>>> +{
>>> + return bcsr_regs;
>>> +}
>>
>> Is get_bcsr() needed since you removed its use from ucc_geth? (if
>> not, let's remove it and the header as well).
>>
>
> it will be once we figure out a better way of handling it from usb
> and ethernet phy code. I had just removed it due to Paul's comment
> (bcsr bits are being manipulated in the wrong place (ucc_geth)).
ok, but nothing is using it in the tree anymore.
Clearly, the phy support for ucc_geth needs to move over to using the
phylib and I think Andy was looking at how to provide board level
hooks to the phylib.
- k
More information about the Linuxppc-dev
mailing list