[2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
bunk at stusta.de
Tue Oct 3 15:07:48 EST 2006
On Mon, Oct 02, 2006 at 09:55:27PM -0700, Andrew Morton wrote:
> On Tue, 03 Oct 2006 14:49:39 +1000
> Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote:
> > On Mon, 2006-10-02 at 21:44 -0700, Andrew Morton wrote:
> > > On Tue, 03 Oct 2006 14:37:25 +1000
> > > Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote:
> > >
> > > > > > You might want to convince Andrew accepting my patch to make
> > > > > > virt_to_bus/bus_to_virt give compile warnings on i386 for making
> > > > > > people more aware of this problem...
> > > > > >...
> > > >
> > > > Andrew, is there any reason not to take that patch ?
> > >
> > > It generates lots of warnings from drivers which nobody does any work on.
> > >
> > > Net result: lots of new warnings, no fixed bugs.
> > Are you sure the warnings won't cause somebody like Al to go through
> > them all and fix them ?
> The drivers simply don't link on some architectures, due to missing
> virt_to_bus/bus_to_virt. They aren't hard to find.
As my patch description says, there had even been one bus_to_virt()
accidentally added in 2.6.17-rc1.
Shouldn't people become aware of it as early and as often as possible?
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
More information about the Linuxppc-dev