[PATCH 1/15] Update for ucc_geth driver
paulus at samba.org
Mon Oct 2 17:24:58 EST 2006
Kim Phillips writes:
> if (bcsr_regs == NULL)
> - bcsr_regs = (u8 *) ioremap(BCSR_PHYS_ADDR, BCSR_SIZE);
> + bcsr_regs = get_bcsr();
> bcsr_regs |= 0x40;
Umm, if the BSCR is really so unique to each board, how come this
driver is frobbing a specific bit? How does the ucc_geth driver know
about the layout of a given board's BCSR?
Also, this patch means that the kernel won't build (assuming you have
the ucc_geth driver in your config) until we get to patch 9/15, where
get_bcsr gets defined.
Lastly, shouldn't this patch be going through Jeff Garzik?
More information about the Linuxppc-dev