[PATCH 16/16] Supporting spidernet on Celleb

Ishizaki Kou kou.ishizaki at toshiba.co.jp
Fri Nov 17 21:42:46 EST 2006


Hi Arnd-san,

Thank you for commenting.

>This should not be required. If you PCI bus is set up
>correctly, pci_device_to_OF_node() will do the right thing.
>What problem are you trying to solve here?

Now we have no problem about that. We'll remove this change.

>You should not need a cast here. It's better to cast the data value
>in the function itself than casting the function pointer. This makes
>sure we notice when the prototype of the function pointer changes.

We'll change the code as you commented.

>   Arnd <><


Thank you,
Kou Ishizaki
Toshiba



More information about the Linuxppc-dev mailing list